Enhance controlling manually braccio #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Memory usage change @ ffd88d7
Click for full report table
Click for full report CSV |
|
I updated the code with the Braccio.lvgl_lock/unlock statements and commented on it. The code is good, but it is slow to respond to the commands with the joystick. That is something that we don't see in the project 02 code. With this new example, we will have two similar codes ( |
Esquirio
reviewed
May 3, 2022
I couldn't test it with the braccio attached, tomorrow morning I'm going to investigate on it. It might be due to the delay inside the if statement of the loop. Is a scope creep of this PR - but - a refactoring in the library on how the lvgl driver functions are exposed would be helpful in order to allow to customize the KEY events paired with the physical buttons. This slowness would be surely overcome if all input buttons could be read as KEY_ENTER events in this sketch, making possible to use the LV_EVENT_PRESSING and LV_EVENT_RELEASED inside the event handler when left,right,up,down joystick buttons are used. |
|
After you test it, you could try to create multiple screens for each layout (shoulder, elbow, wrist, and gripper), or you can delete the button matrix object and recreate it again with the new design. I think one of these updates should fix the problem. |
In the code, it was missing the Braccio.lvgl_lock/unlock statements to avoid multi-threaded access to LVGL.
aentinger
force-pushed
the
enhance_controlling_manually_braccio
branch
from
414975a to
5ff8dde
Compare
Good input, I'll take it into considerations. |
|
I did a fair bit of rework on the example. Please test it and let me know what you think. I'm experiencing a bit of jerkiness of the arm which is caused due to |
|
This code is the most stable of all. I ran the code many times, and it worked most of the time correctly. Now, the response of the movements when we move the joystick is quick. Once or twice, I had to restart the Arduino because the movement of the Elbow and the wrist didn't work well, but I couldn't figure out why it was necessary. |
per1234
added
topic: documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced version of the manually-controlling-braccio example:
Note: since the driver definition and hardware buttons mapping happens inside the library and that only the "KEY_ENTER" lvgl input triggers the LV_EVENT_PRESSED/PRESSING/RELEASED, is not possible to achieve a "push button" behavior without adding a routine in loop that check if Braccio.getKey() has changed to zero in order to remove the checked state.
The definition of another input driver for this example where each input is identified as KEY_ENTER would make possible to exploit the states of lvgl with all the physical inputs.